Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Exit gracefully on artwork and sourcecode src file access errors #1203

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kesara
Copy link
Member

@kesara kesara commented Jan 16, 2025

Fixes #1125

@rjsparks
Copy link
Member

This changes the overall behavior to "exit on first error" rather than "list all errors". Is that necessary?
I think #1125 was complaining more about the lack of a human-readable interpretation of what had gone wrong than it was the stack trace hiding the error.

@kesara
Copy link
Member Author

kesara commented Jan 16, 2025

This changes the overall behavior to "exit on first error" rather than "list all errors". Is that necessary? I think #1125 was complaining more about the lack of a human-readable interpretation of what had gone wrong than it was the stack trace hiding the error.

This changes the overall behavior to "exit on first error" rather than "list all errors". Is that necessary? I think #1125 was complaining more about the lack of a human-readable interpretation of what had gone wrong than it was the stack trace hiding the error.

xml2rfc doesn't have a builtin functionality to list errors and not generate an output.
If we are to list these errors, xml2rfc will output something with empty art work/sourcecode.

EDIT: Exception being the parser, where it list errors and on-certain errors xml2rfc exits. But this happens after the parsing in prep stage.

@cabo
Copy link
Contributor

cabo commented Jan 16, 2025

xml2rfc doesn't have a builtin functionality to list errors and not generate an output.
If we are to list these errors, xml2rfc will output something with empty art work/sourcecode.

Which may be exactly what you want during editing the document.

(FYI, kramdown-rfc does not use src=.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing file reported poorly for <sourcecode src=...>
3 participants