Skip to content

Commit

Permalink
v2.0.12
Browse files Browse the repository at this point in the history
 * client resets of HTTP/2 streams led to unwanted 500 errors
   reported in access logs and error documents. The processing of the
   reset was correct, only unneccesary reporting was caused.
  • Loading branch information
icing committed Jan 29, 2023
1 parent 99395e4 commit c866d4b
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 4 deletions.
9 changes: 9 additions & 0 deletions ChangeLog
Original file line number Diff line number Diff line change
@@ -1,3 +1,12 @@
v2.0.12
--------------------------------------------------------------------------------
* client resets of HTTP/2 streams led to unwanted 500 errors
reported in access logs and error documents. The processing of the
reset was correct, only unneccesary reporting was caused.
* Upgrade requests from HTTP/1.1 to HTTP/2 via the "Upgrade" header were
always ignored for a request with a body. The check for this was incomplete
and missed bodies announced via "Transfer-Encoding". Fixed. Refs #243

v2.0.11
--------------------------------------------------------------------------------
* WARNING: the directive "H2HeaderStrictness" from v2.0.4 has been
Expand Down
2 changes: 1 addition & 1 deletion configure.ac
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
#

AC_PREREQ([2.69])
AC_INIT([mod_http2], [2.0.11], [[email protected]])
AC_INIT([mod_http2], [2.0.12], [[email protected]])

LT_PREREQ([2.2.6])
LT_INIT()
Expand Down
2 changes: 1 addition & 1 deletion mod_http2/h2_c2_filter.c
Original file line number Diff line number Diff line change
Expand Up @@ -615,7 +615,7 @@ apr_status_t h2_c2_filter_catch_h1_out(ap_filter_t* f, apr_bucket_brigade* bb)
ap_assert(conn_ctx);
H2_FILTER_LOG("c2_catch_h1_out", f->c, APLOG_TRACE2, 0, "check", bb);

if (!conn_ctx->has_final_response) {
if (!f->c->aborted && !conn_ctx->has_final_response) {
if (!parser) {
parser = apr_pcalloc(f->c->pool, sizeof(*parser));
parser->id = apr_psprintf(f->c->pool, "%s-%d", conn_ctx->id, conn_ctx->stream_id);
Expand Down
4 changes: 2 additions & 2 deletions mod_http2/h2_version.h
Original file line number Diff line number Diff line change
Expand Up @@ -27,15 +27,15 @@
* @macro
* Version number of the http2 module as c string
*/
#define MOD_HTTP2_VERSION "2.0.11-git"
#define MOD_HTTP2_VERSION "2.0.12-git"

/**
* @macro
* Numerical representation of the version number of the http2 module
* release. This is a 24 bit number with 8 bits for major number, 8 bits
* for minor and 8 bits for patch. Version 1.2.3 becomes 0x010203.
*/
#define MOD_HTTP2_VERSION_NUM 0x02000b
#define MOD_HTTP2_VERSION_NUM 0x02000c


#endif /* mod_h2_h2_version_h */

0 comments on commit c866d4b

Please sign in to comment.