net/proxy/ares:resolver fix a leak

iceboy233 · Jan 3, 2023 · 71468ec · 71468ec
1 parent 51cebb2
commit 71468ec
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/net/proxy/ares/resolver.cc b/net/proxy/ares/resolver.cc
@@ -190,9 +190,11 @@ void Resolver::Operation::finish(
     for (auto &callback : callbacks) {
         std::move(callback)(operation->ec_, operation->addresses_);
     }
-    if (!operation->ec_) {
-        operation->cache();
+    if (operation->ec_) {
+        delete operation;
+        return;
     }
+    operation->cache();
 }
 
 void Resolver::Operation::parse(int status, ares_addrinfo *ai) {