Consistently load OpenSSL libraries among different platforms #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @keithc-ca |
|
Moving to draft state based on ibmruntimes/openj9-openjdk-jdk#884 (comment). |
keithc-ca
requested changes
Jan 16, 2025
As part of this pull request, these changes are performed: - Allow loading specific user-defined OpenSSL library using the -Djdk.native.openssl.lib option. - OpenSSL library loading is consolidated into a single file using ifdefs. - The platform-specific MD files are no longer needed and are thus deleted. - Additional traces are added to indicate the attempts and actual OpenSSL library loaded. - The location of the library loaded is printed. Moreover, the order of preference for loading a library is updated to follow this order: 1. Explicitly load what was specified via JVM property. Fail if loading fails. 2. Search within the Semeru directories for a bundled version. 3. Search the system for existing libraries and attempt to find the higher version. 4. If all of the previous steps fail, revert to original Java implementation for crypto. Co-authored by: Paritosh Kumar <[email protected]> Co-authored by: Kostas Tsiounis <[email protected]> Signed-off-by: Kostas Tsiounis <[email protected]>
KostasTsiounis
force-pushed
the
ossl_load
branch
from
7ff900a to
c3f84c1
Compare
|
Jenkins line endings check |
|
Jenkins compile aix,osx,plinux jdk11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of this pull request, these changes are performed:
-Djdk.native.openssl.liboption.Moreover, the order of preference for loading a library is updated to follow this order:
Back-ported from: ibmruntimes/openj9-openjdk-jdk#884
Co-authored by: Paritosh Kumar [email protected]
Co-authored by: Kostas Tsiounis [email protected]
Signed-off-by: Kostas Tsiounis [email protected]