-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): isoyear method #9034
Conversation
ACTION NEEDED Ibis follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
@cpcloud I'm not sure where the corresponding tests should be placed?
|
Hey @kaijennissen! For tests of ibis internals, like does the extract operation return the Ibis type we expect for a given input, those go in For testing execution against backends (does the operation do what we want, which backends are implemented, etc), those go in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@kaijennissen I went ahead and added tests and implemented the remaining easy-to-implement backend compilation rules.
Thanks for kicking this off!
Description of changes
Added a new isoyear method for timestamps.
Issues closed
Resolved #8989