Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Make CorDA example work #2300

Merged
merged 2 commits into from
Jan 7, 2025
Merged

FIX: Make CorDA example work #2300

merged 2 commits into from
Jan 7, 2025

Conversation

5eqn
Copy link
Contributor

@5eqn 5eqn commented Dec 30, 2024

Previously when changing load_dataset logic in #2231 , I've forgotten traindataset = [] for dataset codefeedback and wizardlm, so the example doesn't work. In this PR I've fixed this bug, and tested that the example works for all datasets.

Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this. I wonder if it would be easier if we move this line:

to the beginning of the function body. That way, we can ensure that traindataset is always initialized and don't need to call it in each if-else branch. WDYT?

@5eqn
Copy link
Contributor Author

5eqn commented Jan 7, 2025

Thanks for catching this. I wonder if it would be easier if we move this line:

to the beginning of the function body. That way, we can ensure that traindataset is always initialized and don't need to call it in each if-else branch. WDYT?

Thanks for your suggestion! After this move, if someone were to add a dataset, it will indeed be less error-prone. I've updated the code and it's ready for review.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix of the CorDA script. The failing tests are unrelated and flaky, so this is good to be merged.

@BenjaminBossan BenjaminBossan merged commit d967f63 into huggingface:main Jan 7, 2025
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants