chore: set ostruct as a gem dependency #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Ruby 3.4, requiring ostruct without pulling it in as a gem brings up a deprecation warning. Ostruct is used in the cli and sidekiq load check. ``` $ bin/bundle exec honeybadger deploy --environment=production --revision=... [email protected]:.../....git' /home/user/.rbenv/versions/3.4.1/lib/ruby/gems/3.4.0/gems/honeybadger-5.26.1/lib/honeybadger/cli/exec.rb:8: warning: ostruct was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0. You can add ostruct to your Gemfile or gemspec to silence this warning. ``` Added ostruct as a runtime dependency of the gem which should appease the warning.
t27duck
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Ruby 3.4, requiring ostruct without pulling it in as a gem brings up a deprecation warning. Ostruct is used in the cli and sidekiq load check.
Added ostruct as a runtime dependency of the gem which should appease the warning.
Before submitting a pull request, please make sure the following is done:
rake specin the repository root.