Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(between): add ignore value changes flag #412

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

siakc
Copy link

@siakc siakc commented Nov 23, 2024

Sometimes it is useful to only include changes in structure and ignore the value changes. So I added a flag to drop such changes in the report.
--ignore-value-chnages

@siakc siakc force-pushed the ignore-value-changes branch 2 times, most recently from 4e497e7 to 6b01b43 Compare November 23, 2024 15:02
Copy link

codecov bot commented Dec 7, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 16 lines in your changes missing coverage. Please review.

Project coverage is 80.26%. Comparing base (76a7983) to head (6b01b43).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
pkg/dyff/reports.go 0.00% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #412      +/-   ##
==========================================
- Coverage   80.86%   80.26%   -0.60%     
==========================================
  Files          15       15              
  Lines        2069     2088      +19     
==========================================
+ Hits         1673     1676       +3     
- Misses        324      340      +16     
  Partials       72       72              
Flag Coverage Δ
unittests 80.26% <20.00%> (-0.60%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HeavyWombat HeavyWombat self-requested a review December 7, 2024 14:13
@HeavyWombat HeavyWombat self-assigned this Dec 7, 2024
Sometimes it is useful to only include changes in structure and ignore the changes in values. Adding a flag to drop such changes in the report.
-v --ignore-value-chnages
@siakc siakc force-pushed the ignore-value-changes branch from 6b01b43 to 6fe62db Compare December 11, 2024 19:27
@siakc
Copy link
Author

siakc commented Dec 28, 2024

Please note that I fixed test coverage. @HeavyWombat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants