-
-
Notifications
You must be signed in to change notification settings - Fork 32k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add types package for pexpect #134461
Add types package for pexpect #134461
Conversation
Hey there @fbradyirl, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
# Set the discovered hostname as prompt | ||
regex_expression = f"(?i)^{router_hostname}".encode() | ||
cisco_ssh.PROMPT = re.compile(regex_expression, re.MULTILINE) | ||
cisco_ssh.PROMPT = f"(?i)^{router_hostname}" | ||
# Allow full arp table to print at once |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both options (str
and the compiled regex) will technically work. It's typed as just a string in the types package so I used that. Might be a slight inaccuracy in the types.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Proposed change
pexpect
is a requirement for multiple integrations.core/requirements_all.txt
Lines 1629 to 1632 in 3b5455b
The types package is part of the
typeshed
project: https://pypi.org/project/types-pexpect/Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: