Replace binary columns with text

[MrTin]

Why?

Binary columns imposes some unwanted restrictions. Using text will make hive compatible to a wider range of databases and versions. When you are using a more efficient database like Postgres, it makes no difference of varchar and text anyway.

Mysql might experience a performance drawback when creating temporary tables but it's not applicable to our use case. Neither from my understanding, do we need to be able to index these columns.

Affected columns

• contents
• changes

Developer notes

How do I test this @marcelklehr? I can't see any test suite so I would at least want to do some manul acceptance testing however as my knowledge is somewhat limited working with Node, how would I go about? Is there a way for me to specify in eg. my package.json that I would like to use this repository instead of the npm version?

Other

Related to #1
Closes hivejs/hive#108

[marcelklehr]

I think npm-link is probably what you want.

[marcelklehr]

I use local paths in my package.json, though.

[marcelklehr]

Confirmed to work with postgres! (had some fun creating a 1.6M file ;) )

[MrTin]

Thanks! According to http://sailsjs.org/documentation/concepts/models-and-orm/attributes mediumtext and longtext are supported as well. It's also supported by MySQL and Postgres which covers the most common databases I would say :)

Let me know if you want me to change this. My suggestion is to go with mediumtext as 16M should be plenty of space for a document ;-)

I'll test this out on my machine to verify if this is the culprit of the bug and report back in a bit!

[MrTin]

Confirmed, this is now working perfectly :)

Just need your decision on what column type to go for 👍

[marcelklehr]

Let's go with mediumtext, then! :)

[MrTin]

Sorry for the slow fix. I just updated this to use mediumtext instead. Should be ready to go unless you would like me to add tests anywhere?

[marcelklehr]

No problem. Life always gets the better of us ;)
And the thing with tests is: there are none (yet). The first place to add some would probably be in hive-core as hive-ui is rapidly changing, atm.

[MrTin]

Sure does ;) Following with excitement!