-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wip: wait for idle during build #349
Draft
hi-ogawa
wants to merge
8
commits into
refactor-build-server-client-reference
Choose a base branch
from
wip-defer-internal
base: refactor-build-server-client-reference
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
wip: wait for idle during build #349
hi-ogawa
wants to merge
8
commits into
refactor-build-server-client-reference
from
wip-defer-internal
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 5, 2024
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
hi-ogawa
changed the title
wip: experiment with emitFile for server reference
wip: wait for idel
Jun 5, 2024
5 tasks
hi-ogawa
force-pushed
the
refactor-build-server-client-reference
branch
from
June 5, 2024 07:12
be83031
to
a6f8485
Compare
hi-ogawa
force-pushed
the
wip-defer-internal
branch
from
June 5, 2024 07:12
6f5c84e
to
afdf4ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ouch, so the hardest part to do in Vite 5 is that
manager.buildType = "client" | "rsc"
cannot be used for parallel build...It's used mostly for assertions, so technically we can just remove them?