-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add XAttr to Link struct #4
base: dev
Are you sure you want to change the base?
Conversation
…d can be used to obtain the correct size and modification time of a file without further API requests.
Hey @lawmurray thanks for the PR! Can you confirm that you have run the integration test on the rclone side when this change is in place? Thank you! |
Yes, if by rlcone integration tests you mean |
Is there anything more that you need from me to merge this and the related PR @henrybear327? Would be nice to get this work included in the rclone 1.69 milestone that's due by 20 October. |
Hey @lawmurray, Sorry for missing this email notification completely :( I am in the process of moving this repo under the rclone org umbrella, so you can merge things directly soon! Henry |
Okay, thanks @henrybear327. This particular pull request is almost trivial by the way, it just adds an attribute to a struct needed to get at the new information, and the other pull request that you already merged (henrybear327/Proton-API-Bridge#28) depends on it. |
Sorry to keep pestering you @henrybear327 but my contributions to rclone are blocked on this and it's a one line change. Can you merge? I think it may also be necessary for you to make new releases on @henrybear327/go-proton-api and @henrybear327/Proton-API-Bridge and update version numbers of the dependency in rclone in order for it to pick up the changes. I'd like to get this out to Proton users and continue helping to improve Proton support in rclone. |
This simply adds an
XAttr
field to theLink
struct, as the JSON response for links (in e.g.ListChildren()
) contains such a field, and it can be used to obtain the size and modification time of the original plaintext (not encrypted) file without further API calls, which can offer some big performance improvements (ref. rclone/rclone#8058).From my tests, it exactly matches the
XAttr
field of the active revision obtained withListRevisions()
.(Side note: The active revision data included in the link JSON has an empty
XAttr
field, which may seem a little odd, but presumably it's because it would be redundant with the link'sXAttr
field, so there's no need to repeat it.)