Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use the upstream interface name #31

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

major0
Copy link

@major0 major0 commented Jan 16, 2025

The commit revision naming seems to have been introduced by proton-api-bridge in a custom fork simply due to their personal preferences regarding the API call. This name change functionally breaks backwards compatibility with the upstream proton-go-api, as well as any other tools using proton-go-api. Such breaking changes need to be justified and can not simply be a matter of naming preferences.

The commit revision naming seems to have been introduced by
proton-api-bridge in a custom fork simply due to their personal
preferences regarding the API call. This name change functionally breaks
backwards compatibility with the upstream proton-go-api, as well as any
other tools using proton-go-api. Such breaking changes need to be
justified and can not simply be a matter of naming preferences.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant