Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: paralleltest #913

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

chore: paralleltest #913

wants to merge 25 commits into from

Conversation

FoseFx
Copy link
Member

@FoseFx FoseFx commented Dec 19, 2024

Which issues does this pull request close?

Re: #865

Enables paralleltest linter, by calling t.Parallel() for every test, for this:

  • remove global state for db and otel Registry (now injected into start-up context)
  • add middlewares to propagate these values into the request contexts
  • rename GetDB to MustGetDB, and require context as parameter
  • add AddUserToOrganization (to unify a common pattern in test code into a proper function)

This should also enable test code to create other services than the own.

@FoseFx FoseFx self-assigned this Dec 19, 2024
@FoseFx FoseFx force-pushed the issue/865-paralleltest branch from 31d8156 to 238bf9b Compare December 19, 2024 16:03
@FoseFx FoseFx changed the title I paid for whole CPU, might as well use it I paid for the whole CPU, might as well use it Dec 19, 2024
@FoseFx FoseFx marked this pull request as ready for review December 27, 2024 12:31
@FoseFx FoseFx requested a review from a team as a code owner December 27, 2024 12:31
@FoseFx FoseFx removed the request for review from a team December 27, 2024 12:31
@FoseFx FoseFx changed the title I paid for the whole CPU, might as well use it chore: paralleltest Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant