clarify global scope meaning for named templates #1662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louis GERARD <[email protected]>
TerryHowe
reviewed
Dec 22, 2024
Co-authored-by: Terry Howe <[email protected]> Signed-off-by: lgerard-pass <[email protected]>
|
@TerryHowe do you know if there are any active maintainers for this project? It looks like work has seriously stalled here. |
|
@yxxhero @karenhchu could you please chime in here? |
sabre1041
suggested changes
Jan 7, 2025
Co-authored-by: Andrew Block <[email protected]> Signed-off-by: Karen Chu <[email protected]>
karenhchu
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just got bitten by the fact that you cannot use the
$sign to access the root context when using a named template.This should solve #1399