Run formatter from Document directory #12315
Open
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses issue helix-editor#10187
robgonnella
force-pushed
the
issue-10187-use-document-dir-when-formatting
branch
from
739cda7 to
75c8980
Compare
robgonnella
changed the title
|
This is an attempt to solve an issue where the external formatter is run from the directory in which helix was launched rather than from the working directory of the document / buffer being updated. In mono-repos this results in a failure to detect formatter configs in subdirectories. I'm new to Rust and this project so apologies if my approach is way off here. Any feedback is greatly appreciated! |
robgonnella
force-pushed
the
issue-10187-use-document-dir-when-formatting
branch
from
1e83176 to
2c8fe9f
Compare
robgonnella
force-pushed
the
issue-10187-use-document-dir-when-formatting
branch
from
2c8fe9f to
93d1514
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #10187