Fix WAN advanced network YML example indentation #886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update intro paragraph (missing content), additions and tweaks to Synchronizing WAN Clusters section
JamesHazelcast
added
documentation
✅ Deploy Preview for hardcore-allen-f5257d ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rebekah-lawrence
approved these changes
Oct 27, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Oct 29, 2023
* Add "last replication wins" info to modes doc * Updates to Advanced Features Update intro paragraph (missing content), additions and tweaks to Synchronizing WAN Clusters section * Hyperlink fix * Advanced Features feedback changes * Advanced Features feedback part 2 * WAN rep modes feedback * Typo fix * YAML config example indentation fix * Fix incorrect endpoint reference (cherry picked from commit 098be2d)
github-actions bot
pushed a commit
that referenced
this pull request
Oct 29, 2023
* Add "last replication wins" info to modes doc * Updates to Advanced Features Update intro paragraph (missing content), additions and tweaks to Synchronizing WAN Clusters section * Hyperlink fix * Advanced Features feedback changes * Advanced Features feedback part 2 * WAN rep modes feedback * Typo fix * YAML config example indentation fix * Fix incorrect endpoint reference (cherry picked from commit 098be2d)
github-actions bot
pushed a commit
that referenced
this pull request
Oct 29, 2023
* Add "last replication wins" info to modes doc * Updates to Advanced Features Update intro paragraph (missing content), additions and tweaks to Synchronizing WAN Clusters section * Hyperlink fix * Advanced Features feedback changes * Advanced Features feedback part 2 * WAN rep modes feedback * Typo fix * YAML config example indentation fix * Fix incorrect endpoint reference (cherry picked from commit 098be2d)
github-actions bot
pushed a commit
that referenced
this pull request
Oct 29, 2023
* Add "last replication wins" info to modes doc * Updates to Advanced Features Update intro paragraph (missing content), additions and tweaks to Synchronizing WAN Clusters section * Hyperlink fix * Advanced Features feedback changes * Advanced Features feedback part 2 * WAN rep modes feedback * Typo fix * YAML config example indentation fix * Fix incorrect endpoint reference (cherry picked from commit 098be2d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example is currently incorrect as
wan-replicationandmapare listed as child nodes ofadvanced-networkwhen they should be child nodes ofhazelcast.The
endpointreference is also incorrect in the current example, and fixed with this PR.