Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure docker versions are correct for OS/EE [DOC-238] #1420

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

JackPGreen
Copy link
Contributor

@JackPGreen JackPGreen commented Dec 5, 2024

Following on from #1355 (comment), ensure the versions of referenced Docker images are correctly differentiating between OS & EE.

Note - not backporting to v/5.5 as doesn't contain these properties.

Slack discussion

Partially addresses:

Following on from hazelcast#1355 (comment), ensure the versions of referenced Docker images are correctly differentiating between OS & EE.

[Slack discussion](https://hazelcast.slack.com/archives/C035HQET5/p1733424118024969)

_Partially_ addresses:
- [DOC-238](https://hazelcast.atlassian.net/browse/DOC-238)
- [DEX-304](https://hazelcast.atlassian.net/browse/DEX-304)
@JackPGreen JackPGreen requested a review from Patras3 December 5, 2024 22:33
@JackPGreen JackPGreen self-assigned this Dec 5, 2024
@JackPGreen JackPGreen requested a review from a team as a code owner December 5, 2024 22:33
Copy link

netlify bot commented Dec 5, 2024

Deploy Preview for hardcore-allen-f5257d ready!

Name Link
🔨 Latest commit 1590671
🔍 Latest deploy log https://app.netlify.com/sites/hardcore-allen-f5257d/deploys/67522a31a1aa8400083409e5
😎 Deploy Preview https://deploy-preview-1420--hardcore-allen-f5257d.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JackPGreen JackPGreen enabled auto-merge (squash) December 5, 2024 22:34
Copy link

@Patras3 Patras3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Contributor

@Rob-Hazelcast Rob-Hazelcast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Jack

@JackPGreen JackPGreen merged commit 081d1ff into hazelcast:main Dec 6, 2024
6 checks passed
@JackPGreen JackPGreen deleted the fix-docker-versions branch December 6, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants