Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about limit indirectly impacting quality [AI-269] #1412

Merged
merged 4 commits into from
Dec 3, 2024

Conversation

k-jamroz
Copy link
Contributor

@k-jamroz k-jamroz commented Dec 3, 2024

During investigation of https://hazelcast.atlassian.net/browse/AI-269 it was uncovered that limit impact on search quality is nonintuitive and unexpected.

More detailed description will follow later, as part of 6.0 changes, in particular efSearch hint and paritionLimit heuristics. The part described in this PR applies equally to 5.5 and 6.0 although in a slightly different way under the hood.

@k-jamroz k-jamroz requested a review from a team as a code owner December 3, 2024 14:07
@k-jamroz k-jamroz requested a review from olukas December 3, 2024 14:07
Copy link

netlify bot commented Dec 3, 2024

Deploy Preview for hardcore-allen-f5257d ready!

Name Link
🔨 Latest commit 8a43b18
🔍 Latest deploy log https://app.netlify.com/sites/hardcore-allen-f5257d/deploys/674f29d6fc1fb6000801548b
😎 Deploy Preview https://deploy-preview-1412--hardcore-allen-f5257d.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k-jamroz k-jamroz added the backport to 5.5 Backport commits from main to v/5.5 label Dec 3, 2024
Copy link
Contributor

@amandalindsay amandalindsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made a suggestion regarding the note - let me know what you think (I'm not a subject matter expert)

@k-jamroz k-jamroz merged commit d5f469e into main Dec 3, 2024
6 checks passed
@k-jamroz k-jamroz deleted the vector-limit-affects-quality branch December 3, 2024 17:01
@k-jamroz k-jamroz added backport to 5.5 Backport commits from main to v/5.5 and removed backport to 5.5 Backport commits from main to v/5.5 labels Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport to 5.5 Backport commits from main to v/5.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants