Add documentation for using DataConnectionService [SUP-523] #1361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frant-hartm
requested review from
oliverhowell and
amandalindsay
as code owners
✅ Deploy Preview for hardcore-allen-f5257d ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@oliverhowell @amandalindsay Before jumping on this one, it might be worth waiting to have devs/QE to review it first - I am not 100 % sure it's all understandable. |
TomaszGaweda
requested changes
Nov 4, 2024
docs/modules/data-connections/pages/data-connection-service.adoc
Outdated
Show resolved
Hide resolved
docs/modules/data-connections/pages/data-connection-service.adoc
Outdated
Show resolved
Hide resolved
docs/modules/data-connections/pages/data-connection-service.adoc
Outdated
Show resolved
Hide resolved
docs/modules/data-connections/pages/data-connection-service.adoc
Outdated
Show resolved
Hide resolved
docs/modules/data-connections/pages/data-connection-service.adoc
Outdated
Show resolved
Hide resolved
docs/modules/data-connections/pages/data-connection-service.adoc
Outdated
Show resolved
Hide resolved
docs/modules/data-connections/pages/how-to-map-loader-data-connection.adoc
Outdated
Show resolved
Hide resolved
Co-authored-by: Tomasz Gawęda <[email protected]>
Rob-Hazelcast
requested changes
Nov 22, 2024
docs/modules/data-connections/pages/data-connection-service.adoc
Outdated
Show resolved
Hide resolved
docs/modules/data-connections/pages/data-connection-service.adoc
Outdated
Show resolved
Hide resolved
docs/modules/data-connections/pages/how-to-map-loader-data-connection.adoc
Show resolved
Hide resolved
docs/modules/data-connections/pages/how-to-pipeline-service-data-connection.adoc
Outdated
Show resolved
Hide resolved
docs/modules/data-connections/pages/how-to-pipeline-service-data-connection.adoc
Outdated
Show resolved
Hide resolved
docs/modules/data-connections/pages/how-to-pipeline-service-data-connection.adoc
Outdated
Show resolved
Hide resolved
docs/modules/data-connections/pages/how-to-pipeline-service-data-connection.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Looking much better, just a couple of outstanding issues. Most important is to reference the new files in nav.adoc. It would be nice to have a validation rule for this @oliverhowell!
ollyhowell
approved these changes
Dec 4, 2024
TomaszGaweda
approved these changes
Dec 4, 2024
Rob-Hazelcast
approved these changes
Dec 4, 2024
devOpsHazelcast
pushed a commit
to hazelcast/hazelcast
that referenced
this pull request
Dec 4, 2024
Although this PR extends the public API, it only makes the DataConnectionService more easily available. Previously it was only available via ProcessorMetaSupplier.Context#dataConnectionService(). There are no changes to the DataConnectionService itself. The service is available only on the member, on the client the method throws exception. Related documentation PR: hazelcast/hz-docs#1361 Re-submission of original PR: https://github.com/hazelcast/hazelcast-mono/pull/3533 GitOrigin-RevId: 6fa1512e67b6657331ff4ba2afb3d6ab5cd6c0b6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related platform PR https://github.com/hazelcast/hazelcast-mono/pull/3533