Only apply milestone to PR if it exists [DOC-268] #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a milestone doesn't exist, [an error is thrown when doing a backport](https://github.com/JackPGreen2/hz-docs/actions/runs/11963090837/job/33352851231#step:7:96). Not all repositories use milestones - instead it should only be applied to the PR, _if it exists_. Fixes: [DOC-268](https://hazelcast.atlassian.net/browse/DOC-268)
ldziedziul
approved these changes
Nov 22, 2024
JackPGreen
added a commit
to hazelcast/hz-docs
that referenced
this pull request
Dec 2, 2024
…8] (#1396) In [DOC-255](https://hazelcast.atlassian.net/browse/DOC-255), branch protection was added - preventing direct `push`es. Instead, the backport workflow should create PRs to backport the changes. This gives the _possibility_ for pre-merge checks to be run (i.e. preventing introducing dead links etc). Leverages [_existing_ `backport` tool](https://github.com/hazelcast/backport), but exposed some issues which need to be addressed **before this can be merged**: - hazelcast/backport#14 - hazelcast/backport#15 - hazelcast/backport#16 - hazelcast/backport#17 Tested in a [test repo](https://github.com/JackPGreen2/hz-docs), where a [dummy PR](JackPGreen2#5) was [successfully backported](JackPGreen2#16). However, due to the complexity of fork-triggering, it wil need to be re-tested once merged. Fixes: [DOC-268](https://hazelcast.atlassian.net/browse/DOC-268) [DOC-255]: https://hazelcast.atlassian.net/browse/DOC-255?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [DOC-268]: https://hazelcast.atlassian.net/browse/DOC-268?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a milestone doesn't exist, an error is thrown when doing a backport.
Not all repositories use milestones - instead it should only be applied to the PR, if it exists.
Fixes: DOC-268