-
-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⬆️ Upgrades UniFi Network Application to 9.0.108 #543
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThe pull request updates the Unifi Dockerfile to upgrade the Unifi software version from 8.6.9 to 9.0.108. This change involves modifying the package download URL to fetch the newer version, which will be installed during the Docker image build process. The update is a straightforward version bump that does not alter any other aspects of the Dockerfile's configuration or structure. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
unifi/Dockerfile (1)
20-20
: Consider using build arg for UniFi versionTo make future upgrades easier and more maintainable, consider using a build argument for the UniFi version.
+ARG UNIFI_VERSION=9.0.108 RUN \ apt-get update \ && apt-get upgrade -y \ && apt-get install -y --no-install-recommends \ binutils=2.34-6ubuntu1.9 \ libcap2=1:2.32-1ubuntu0.1 \ logrotate=3.14.0-4ubuntu3 \ mongodb-server=1:3.6.9+really3.6.8+90~g8e540c0b6d-0ubuntu5.3 \ openjdk-17-jre-headless=17* \ \ && curl -J -L -o /tmp/unifi.deb \ - "https://dl.ui.com/unifi/9.0.108/unifi_sysvinit_all.deb" \ + "https://dl.ui.com/unifi/${UNIFI_VERSION}/unifi_sysvinit_all.deb" \
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
unifi/Dockerfile
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: workflows / Build amd64
- GitHub Check: workflows / Build aarch64
🔇 Additional comments (3)
unifi/Dockerfile (3)
20-20
: Major version upgrade: Review breaking changesThis is a major version upgrade from 8.x to 9.x. Please ensure you've reviewed the release notes for any breaking changes that might affect users.
Consider:
- Adding upgrade instructions to the PR description
- Documenting any required configuration changes
- Highlighting new features or behavioral changes
20-20
: Verify MongoDB compatibility with UniFi 9.0.108The Dockerfile uses MongoDB 3.6.8 which is quite old. Let's verify if this version is still supported with UniFi 9.0.108.
20-20
: Verify security implications of the upgradeLet's check if this version addresses any security issues or has known vulnerabilities.
Do we need to upgrade MongoDB for this one? |
No. |
Rel notes: https://community.ui.com/releases/UniFi-Network-Application-9-0-108/248de26a-ad59-4d01-b8eb-33556fa9683b
https://community.ui.com/releases/r/network/9.0.108
Summary by CodeRabbit