Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Upgrades UniFi Network Application to 9.0.108 #543

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cwmoriarty
Copy link
Contributor

@cwmoriarty cwmoriarty commented Jan 6, 2025

Rel notes: https://community.ui.com/releases/UniFi-Network-Application-9-0-108/248de26a-ad59-4d01-b8eb-33556fa9683b

https://community.ui.com/releases/r/network/9.0.108

Summary by CodeRabbit

  • Chores
    • Updated Unifi software version from 8.6.9 to 9.0.108 in the Dockerfile
    • Routine version upgrade of Unifi package

Copy link

coderabbitai bot commented Jan 6, 2025

Walkthrough

The pull request updates the Unifi Dockerfile to upgrade the Unifi software version from 8.6.9 to 9.0.108. This change involves modifying the package download URL to fetch the newer version, which will be installed during the Docker image build process. The update is a straightforward version bump that does not alter any other aspects of the Dockerfile's configuration or structure.

Changes

File Change Summary
unifi/Dockerfile Updated Unifi software version from 8.6.9 to 9.0.108

Poem

🐰 A Dockerfile's Hop to Newer Heights

From version eight to nine we leap,
Unifi's package gets a version sweep
Curl fetches bits with bunny might
Upgrading software, pure delight! 🚀
A version bump, so clean and bright


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
unifi/Dockerfile (1)

20-20: Consider using build arg for UniFi version

To make future upgrades easier and more maintainable, consider using a build argument for the UniFi version.

+ARG UNIFI_VERSION=9.0.108
 RUN \
     apt-get update \
     && apt-get upgrade -y \
     && apt-get install -y --no-install-recommends \
         binutils=2.34-6ubuntu1.9 \
         libcap2=1:2.32-1ubuntu0.1 \
         logrotate=3.14.0-4ubuntu3 \
         mongodb-server=1:3.6.9+really3.6.8+90~g8e540c0b6d-0ubuntu5.3 \
         openjdk-17-jre-headless=17* \
     \
     && curl -J -L -o /tmp/unifi.deb \
-        "https://dl.ui.com/unifi/9.0.108/unifi_sysvinit_all.deb" \
+        "https://dl.ui.com/unifi/${UNIFI_VERSION}/unifi_sysvinit_all.deb" \
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 55dfd2f and 61c1bca.

📒 Files selected for processing (1)
  • unifi/Dockerfile (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: workflows / Build amd64
  • GitHub Check: workflows / Build aarch64
🔇 Additional comments (3)
unifi/Dockerfile (3)

20-20: Major version upgrade: Review breaking changes

This is a major version upgrade from 8.x to 9.x. Please ensure you've reviewed the release notes for any breaking changes that might affect users.

Consider:

  1. Adding upgrade instructions to the PR description
  2. Documenting any required configuration changes
  3. Highlighting new features or behavioral changes

20-20: Verify MongoDB compatibility with UniFi 9.0.108

The Dockerfile uses MongoDB 3.6.8 which is quite old. Let's verify if this version is still supported with UniFi 9.0.108.


20-20: Verify security implications of the upgrade

Let's check if this version addresses any security issues or has known vulnerabilities.

@frenck frenck added the dependencies Upgrade or downgrade of project dependencies. label Jan 6, 2025
@frenck
Copy link
Member

frenck commented Jan 6, 2025

Do we need to upgrade MongoDB for this one?

@cwmoriarty
Copy link
Contributor Author

No.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Upgrade or downgrade of project dependencies.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants