Move all pki-verification calls from sdk-Verify() to pki-specific #29342
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VerifyCertifcate(...); update sdk-Verify to allow multiple chains, but validate that at least one of those chains is valid.
Description
This updates the "Verify" call in the SDK to allow multiple chains, but do more enforcement to check that at least one of those chains is valid.
--
builtin/logical/database/credentials.go ; line 269
--
physical/cassandra/cassandra.go ; line 201
--
plugins/database/influxdb/connection_producer.go ; line 97
This also updates calls inside the PKI secrets engine to use the configurable VerifyCertificate call rather than the sdk-version which lacks the context that Verify includes.
TODO only if you're a HashiCorp employee
backport/
label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x
, but older release branches will bebackport/ent/x.x.x+ent
.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
-- This doesn't change the signature of any function.
in the PR description, commit message, or branch name.