VAULT-21474 Run oidcPeriodicFunc for each namespace id store #29312
+87
−122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not sure why I decided to ignore the NoNamespace error before or not log the unexpected error, that doesn't make sense.
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results: |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Build Results: |
miagilepner
reviewed
Jan 20, 2025
| @@ -0,0 +1,3 @@ | |||
| ```release-note:bug | |||
| identity/oidc: Run OIDC key rotations for each namespace individually. | |||
There was a problem hiding this comment.
Can we also add a change release note to say that the cache control header returned from OIDC queries will only be for the queried namespace?
There was a problem hiding this comment.
It might be good to connect with @austingebauer and @fairclothjm, since I know they've done worth with OIDC before, to try to see whether this change in behavior is problematic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes the identity store rotate only the OIDC keys for its own namespace. This allows the enterprise version, which supports namespaces, to scale to a larger number of namespaces without hitting timeouts on this
oidcPeriodicFuncby dividing the work between multiple executions. For CE this shouldn't change anything.ent PR: vault-enterprise#7164
Jira: VAULT-21474
TODO only if you're a HashiCorp employee
backport/label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x, but older release branches will bebackport/ent/x.x.x+ent.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.