Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add information about an enterprise feature related to validating iss… #29300

Conversation

kitography
Copy link
Contributor

This is the documentation half to the enterprise feature which added four issuer configurations related to chain validation.

JIRA of this task: https://hashicorp.atlassian.net/browse/VAULT-32535
JIRA of the original task: https://hashicorp.atlassian.net/browse/VAULT-32137
PR of the original (ENT) feature: https://github.com/hashicorp/vault-enterprise/pull/6924
RFC of the overall feature: https://hermes.hashicorp.services/document/1MmCXGZ6dioQ7q7id9ZBUdBK0zUHiobtD3OWGrV8hq4E?draft=true

This doesn't need to be backported.

@kitography kitography added this to the 1.19.0-rc milestone Jan 6, 2025
@kitography kitography requested a review from a team January 6, 2025 21:54
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jan 6, 2025
Copy link

github-actions bot commented Jan 6, 2025

CI Results:
All Go tests succeeded! ✅

@kitography kitography force-pushed the VAULT-32535-update-documentation-add-new-pki-issuer-configuration-fields-to-disable-verification-checks branch from d27448a to 3045fc0 Compare January 6, 2025 22:14
@kitography kitography marked this pull request as ready for review January 6, 2025 22:14
@kitography kitography requested a review from a team as a code owner January 6, 2025 22:14
Copy link

github-actions bot commented Jan 6, 2025

Build Results:
All builds succeeded! ✅

website/content/api-docs/secret/pki/index.mdx Outdated Show resolved Hide resolved
website/content/api-docs/secret/pki/index.mdx Outdated Show resolved Hide resolved
website/content/api-docs/secret/pki/index.mdx Outdated Show resolved Hide resolved
website/content/api-docs/secret/pki/index.mdx Outdated Show resolved Hide resolved
website/content/api-docs/secret/pki/index.mdx Outdated Show resolved Hide resolved
kitography and others added 6 commits January 7, 2025 12:16
Update RFC name and link, as suggested by Steve.

Co-authored-by: Steven Clark <[email protected]>
Update RFC name and link, as suggested by Steve.

Co-authored-by: Steven Clark <[email protected]>
Update RFC name and link, as suggested by Steve.

Co-authored-by: Steven Clark <[email protected]>
Update RFC name and link, as suggested by Steve.

Co-authored-by: Steven Clark <[email protected]>
@kitography kitography force-pushed the VAULT-32535-update-documentation-add-new-pki-issuer-configuration-fields-to-disable-verification-checks branch from d5716c4 to 54b1425 Compare January 7, 2025 17:16
@kitography
Copy link
Contributor Author

Screenshot 2025-01-07 at 12 55 59 PM This does look a lot nicer - thanks @stevendpclark

@kitography kitography merged commit 55ca52f into main Jan 9, 2025
33 of 34 checks passed
@kitography kitography deleted the VAULT-32535-update-documentation-add-new-pki-issuer-configuration-fields-to-disable-verification-checks branch January 9, 2025 16:30
michael-diggin pushed a commit to michael-diggin/vault that referenced this pull request Jan 20, 2025
hashicorp#29300)

* Add information about an enterprise feature related to validating issued certificates to the PKI API docs.

* Update website/content/api-docs/secret/pki/index.mdx

Update RFC name and link, as suggested by Steve.

Co-authored-by: Steven Clark <[email protected]>

* Update website/content/api-docs/secret/pki/index.mdx

Update RFC name and link, as suggested by Steve.

Co-authored-by: Steven Clark <[email protected]>

* Update website/content/api-docs/secret/pki/index.mdx

Update RFC name and link, as suggested by Steve.

Co-authored-by: Steven Clark <[email protected]>

* Update website/content/api-docs/secret/pki/index.mdx

Update RFC name and link, as suggested by Steve.

Co-authored-by: Steven Clark <[email protected]>

* Update enterprise tag to be on the same line for vercel reasons.

---------

Co-authored-by: Steven Clark <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog secret/pki
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants