-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add information about an enterprise feature related to validating iss… #29300
Merged
kitography
merged 6 commits into
main
from
VAULT-32535-update-documentation-add-new-pki-issuer-configuration-fields-to-disable-verification-checks
Jan 9, 2025
Merged
Add information about an enterprise feature related to validating iss… #29300
kitography
merged 6 commits into
main
from
VAULT-32535-update-documentation-add-new-pki-issuer-configuration-fields-to-disable-verification-checks
Jan 9, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
If the PR is HashiCorp (i.e. not-community) contributed
label
Jan 6, 2025
CI Results: |
kitography
force-pushed
the
VAULT-32535-update-documentation-add-new-pki-issuer-configuration-fields-to-disable-verification-checks
branch
from
January 6, 2025 22:14
d27448a
to
3045fc0
Compare
Build Results: |
…ued certificates to the PKI API docs.
Update RFC name and link, as suggested by Steve. Co-authored-by: Steven Clark <[email protected]>
Update RFC name and link, as suggested by Steve. Co-authored-by: Steven Clark <[email protected]>
Update RFC name and link, as suggested by Steve. Co-authored-by: Steven Clark <[email protected]>
Update RFC name and link, as suggested by Steve. Co-authored-by: Steven Clark <[email protected]>
kitography
force-pushed
the
VAULT-32535-update-documentation-add-new-pki-issuer-configuration-fields-to-disable-verification-checks
branch
from
January 7, 2025 17:16
d5716c4
to
54b1425
Compare
This does look a lot nicer - thanks @stevendpclark |
stevendpclark
approved these changes
Jan 7, 2025
yhyakuna
approved these changes
Jan 8, 2025
kitography
deleted the
VAULT-32535-update-documentation-add-new-pki-issuer-configuration-fields-to-disable-verification-checks
branch
January 9, 2025 16:30
michael-diggin
pushed a commit
to michael-diggin/vault
that referenced
this pull request
Jan 20, 2025
hashicorp#29300) * Add information about an enterprise feature related to validating issued certificates to the PKI API docs. * Update website/content/api-docs/secret/pki/index.mdx Update RFC name and link, as suggested by Steve. Co-authored-by: Steven Clark <[email protected]> * Update website/content/api-docs/secret/pki/index.mdx Update RFC name and link, as suggested by Steve. Co-authored-by: Steven Clark <[email protected]> * Update website/content/api-docs/secret/pki/index.mdx Update RFC name and link, as suggested by Steve. Co-authored-by: Steven Clark <[email protected]> * Update website/content/api-docs/secret/pki/index.mdx Update RFC name and link, as suggested by Steve. Co-authored-by: Steven Clark <[email protected]> * Update enterprise tag to be on the same line for vercel reasons. --------- Co-authored-by: Steven Clark <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
docs
hashicorp-contributed-pr
If the PR is HashiCorp (i.e. not-community) contributed
pr/no-changelog
secret/pki
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the documentation half to the enterprise feature which added four issuer configurations related to chain validation.
JIRA of this task: https://hashicorp.atlassian.net/browse/VAULT-32535
JIRA of the original task: https://hashicorp.atlassian.net/browse/VAULT-32137
PR of the original (ENT) feature: https://github.com/hashicorp/vault-enterprise/pull/6924
RFC of the overall feature: https://hermes.hashicorp.services/document/1MmCXGZ6dioQ7q7id9ZBUdBK0zUHiobtD3OWGrV8hq4E?draft=true
This doesn't need to be backported.