-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add aws sdk migration guide #36104
Conversation
This guide will assist community members interested in migrating services from AWS SDK for Go V1 to V2 by documenting common replacement patterns.
Community NoteVoting for Prioritization
For Submitters
|
|
||
### Add an `EndpointID` Constant | ||
|
||
When a service is first migrated, a `{ServiceName}EndpointID` constant must be added to [`names/names.go`](https://github.com/hashicorp/terraform-provider-aws/blob/main/names/names.go) manually. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is no longer the case: acctest.ErrorCheck
should take the corresponding names.<Service>ServiceID
, which is generated. It may still be needed in some cases, such as acctest.PreCheckPartitionHasService
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clarification. I'll fix the syntax in the acceptance testing ErrorCheck section below.
Given skaff
outputs acceptance tests that use the acctest.PreCheckPartitionHasService
PreCheck, and most existing services use it, I think this section may be worth keeping.
Co-authored-by: Kit Ewbank <[email protected]>
This functionality has been released in v5.40.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This guide will assist community members interested in migrating services from AWS SDK for Go V1 to V2 by documenting common replacement patterns.
Relations
Relates #32976
Relates #32917