-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perfect nested sampling functionality #205
Conversation
Codecov Report
@@ Coverage Diff @@
## master #205 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 26 29 +3
Lines 2303 2422 +119
==========================================
+ Hits 2303 2422 +119
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could indeed be useful. Did you intend to add more to this or is this ready for review?
See comments inline.
I have added a planck gaussian example ( One subtlety is that this would not give the same evidence as a full planck run, but we could choose this normalisation a-la-nuisance marginalised likelihoods. In addition I corrected a bug which testing this threw up (a factor of 2 in the It is too inefficient with all nuisance parameters sadly. |
This will also be useful for removing demo.py in #246. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments inline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks @williamjameshandley, please squash and merge.
Description
A set of scripts for generating perfect nested sampling runs which will prove useful in developing techniques such as importance sampling #132.
Changes:
Checklist:
flake8 anesthetic tests
)pydocstyle --convention=numpy anesthetic
)python -m pytest
)