Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong option label of language select #9

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Fix wrong option label of language select #9

merged 1 commit into from
Jan 16, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Jan 16, 2024 •
edited
Loading

before:

图片

now:

图片

/kind bug

修复绘图类型选择的显示文字的问题

@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Jan 16, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and JohnNiang January 16, 2024 06:00
@f2c-ci-robot f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jan 16, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from ruibaby. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 16, 2024
@xinkeng0 xinkeng0 merged commit ce57676 into halo-sigs:main Jan 16, 2024
3 of 4 checks passed
@ruibaby ruibaby deleted the fix/diagram-type-select branch January 16, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guqing guqing Awaiting requested review from guqing

@JohnNiang JohnNiang Awaiting requested review from JohnNiang

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruibaby @xinkeng0