Include setup-scala step in CI #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
akash1810
reviewed
Dec 20, 2024
.tool-versions
Outdated
| @@ -0,0 +1 @@ | |||
| java corretto-21.0.5.11.1 | |||
There was a problem hiding this comment.
We were using Java 11 with actions/setup-java. Here we're using Java 21. Have we tested with this version?
There was a problem hiding this comment.
The deployment process here is a bit mysterious and I don't know what version of Java it uses. I have only tested the CI workflow. I'll set the version to 11 to keep this as an atomic change.
akash1810
approved these changes
Dec 27, 2024
|
Seen on PROD (merged by @kelvin-chappell 5 hours, 10 minutes and 15 seconds ago) Please check your changes! Sentry Release: prout |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the setup-java step with setup-scala now that SBT has to be installed as well.
Setting Java version to latest Corretto LTS release.