Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added github actions #37

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
20 changes: 20 additions & 0 deletions .github/workflows/build.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
name: build

on:
push:
branches: [master]
pull_request:
branches: [master]

jobs:
build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: subosito/flutter-action@v1
with:
flutter-version: "2.0.1"
- run: flutter pub get
- run: flutter analyze


5 changes: 0 additions & 5 deletions lib/commands/app/refresh_menubar_command.dart
Original file line number Diff line number Diff line change
@@ -1,9 +1,4 @@
import 'dart:io';

import 'package:flutter_folio/commands/app/set_current_user_command.dart';
import 'package:flutter_folio/commands/commands.dart';
import 'package:menubar/menubar.dart';
import 'package:universal_platform/universal_platform.dart';

//TODO: Should we pull this feature completely since it's not supported on Windows?
class RefreshMenuBarCommand extends BaseAppCommand {
Expand Down
2 changes: 1 addition & 1 deletion lib/main_app_scaffold.dart
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ class _MainAppScaffoldState extends State<MainAppScaffold> {
return Provider.value(
value: appTheme,
child: StatsFl(
isEnabled: false && (kProfileMode || kDebugMode),
isEnabled: false,
align: Alignment.bottomCenter,
child: Directionality(
textDirection: textDirection,
Expand Down
1 change: 0 additions & 1 deletion lib/models/books_model.dart
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import 'package:flutter_folio/_utils/data_utils.dart';
import 'package:flutter_folio/_utils/easy_notifier.dart';
import 'package:flutter_folio/_utils/string_utils.dart';
import 'package:flutter_folio/data/book_data.dart';
Expand Down
1 change: 0 additions & 1 deletion lib/routing/app_route_parser.dart
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import 'package:flutter/foundation.dart';
import 'package:flutter/material.dart';
import 'package:flutter_folio/core_packages.dart';
import 'package:flutter_folio/routing/app_link.dart';
Expand Down
1 change: 0 additions & 1 deletion lib/routing/app_router.dart
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import 'package:flutter/foundation.dart';
import 'package:flutter/material.dart';
import 'package:flutter_folio/_spikes/auth_spike.dart';
import 'package:flutter_folio/commands/books/set_current_book_command.dart';
import 'package:flutter_folio/commands/books/set_current_page_command.dart';
import 'package:flutter_folio/core_packages.dart';
Expand Down
1 change: 0 additions & 1 deletion lib/services/firebase/firebase_service_firedart.dart
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import 'dart:convert';
import 'package:firedart/auth/user_gateway.dart';
import 'package:firedart/firedart.dart';
import 'package:firedart/firestore/models.dart';
import 'package:flutter_folio/core_packages.dart';
import 'package:flutter_folio/data/app_user.dart';
import 'package:flutter_folio/services/firebase/firebase_service.dart';
import 'package:shared_preferences/shared_preferences.dart';
Expand Down
1 change: 0 additions & 1 deletion lib/services/firebase/firebase_service_native.dart
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ class NativeFirebaseService extends FirebaseService {
super.signOut();
}

@override
bool _isSignedIn = false;
bool get isSignedIn => _isSignedIn;

Expand Down
2 changes: 1 addition & 1 deletion lib/styled_widgets/inline_text_editor.dart
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ class _InlineTextEditorState extends State<InlineTextEditor> {
String lastValue = "";
int lastPosition;
final FocusNode rawFocus = FocusNode();
@override

void _fixTextOnLinux(String value) {
if (value.length > 1 && lastValue.length < value.length) {
final enteredChar = value[0];
Expand Down
1 change: 0 additions & 1 deletion lib/styled_widgets/labeled_text_input.dart
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import 'package:flutter/material.dart';
import 'package:flutter/services.dart';
import 'package:flutter_folio/_utils/string_utils.dart';
import 'package:flutter_folio/_widgets/context_menu_overlay.dart';
import 'package:flutter_folio/core_packages.dart';
import 'package:flutter_folio/models/app_model.dart';
import 'package:universal_platform/universal_platform.dart';
Expand Down
5 changes: 0 additions & 5 deletions lib/views/editor_page/editor_page.dart
Original file line number Diff line number Diff line change
@@ -1,10 +1,7 @@
import 'dart:async';
import 'dart:math';
import 'dart:ui';

import 'package:flutter/material.dart';
import 'package:flutter_folio/_widgets/alignments.dart';
import 'package:flutter_folio/commands/books/refresh_current_book_command.dart';
import 'package:flutter_folio/core_packages.dart';
import 'package:flutter_folio/data/book_data.dart';
import 'package:flutter_folio/models/app_model.dart';
Expand All @@ -13,9 +10,7 @@ import 'package:flutter_folio/views/scrap_pile_picker/scrap_pile_picker.dart';

import 'networked_scrapboard.dart';
import 'empty_scrapboard_view.dart';
import 'panels/collapsible_info_panel.dart';
import 'panels/content_picker_tab_menu.dart';
import 'panels/collapsible_pages_panel.dart';
import 'panels/collapsible_panels.dart';
import 'panels/simple_pages_menu.dart';

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import 'package:flutter/foundation.dart';
import 'package:flutter/gestures.dart';
import 'package:flutter/material.dart';
import 'package:flutter_folio/_utils/debouncer.dart';
import 'package:flutter_folio/_utils/time_utils.dart';
import 'package:flutter_folio/core_packages.dart';

class MovableScrapSelectionBox extends StatefulWidget {
Expand Down
1 change: 0 additions & 1 deletion lib/views/editor_page/scrapboard/scrapboard.dart
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ class ScrapboardState<T> extends State<Scrapboard<T>> with RawKeyboardListenerMi
double _scale = 1;
List<String> _selectedBoxIds = [];
bool _isSpaceBarDown = false;
Size _viewSize;

// We create a copy of the assigned boxList, so we can work on it internally
List<ScrapData<T>> get _tmpBoxes => widget.boxes;
Expand Down
3 changes: 0 additions & 3 deletions lib/views/home_page/covers_sortable_list_widgets.dart
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import 'package:flutter/rendering.dart';
import 'package:flutter_folio/_widgets/animated/animated_rotation.dart';
import 'package:flutter_folio/_widgets/context_menu_overlay.dart';
import 'package:flutter_folio/_widgets/gradient_container.dart';
import 'package:flutter_folio/commands/app/copy_share_link_command.dart';
import 'package:flutter_folio/core_packages.dart';
import 'package:flutter_folio/data/book_data.dart';
import 'package:timeago/timeago.dart' as timeago;
Expand Down Expand Up @@ -198,8 +197,6 @@ class ImageAndNameContent extends StatelessWidget {
],
);
}

void _handleSharePressed() => CopyShareLinkCommand().run(data.documentId);
}

class TextContent extends StatelessWidget {
Expand Down