Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Simplify DefaultFilterDialog #3991

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

bjoernricks
Copy link
Contributor

What

Simplify DefaultFilterDialog

Why

Get the capabilities via the useCapabilities hook instead of using the withCapabilities HOC. Higher order components (HOCs) are more difficult to understand then react hooks.

@bjoernricks bjoernricks requested a review from a team as a code owner April 3, 2024 14:33
@bjoernricks bjoernricks enabled auto-merge (rebase) April 3, 2024 14:33
Copy link

github-actions bot commented Apr 3, 2024

Conventional Commits Report

Type Number
Changed 1

🚀 Conventional commits found.

Get the capabilities via the useCapabilities hook instead of using the
withCapabilities HOC. Higher order components (HOCs) are more difficult
to understand then react hooks.
@a-h-abdelsalam a-h-abdelsalam force-pushed the simplify-default-filter-dialog branch from b4145e2 to d86831f Compare April 4, 2024 08:27
@bjoernricks bjoernricks merged commit c9cb7e0 into main Apr 4, 2024
11 checks passed
@bjoernricks bjoernricks deleted the simplify-default-filter-dialog branch April 4, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants