Fix: Avoid re-render when user settings haven't changed for FilterProvider #3959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vider The behavior of `useSelector` and `connect` is differently. `useSelector` uses identity comparison `===` for detecting if the returned object has changed and a re-render is necessary and `connect` uses shallow comparison. See https://react-redux.js.org/api/hooks#equality-comparisons-and-updates for all details. Therefore to avoid re-renders in the FilterProvider we need to compare the contents of returned array from the user settings selector via `shallowEqual` because with every call a new array is created and the identity changes.
Conventional Commits Report
🚀 Conventional commits found. |
a-h-abdelsalam
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Avoid unnecessary re-renders in FilterProvider when getting the rowsPerPage settings from the redux store.
Why
The behavior of
useSelectorhook and "old"connectfunction is differently.useSelectoruses identity comparison===for detecting if the returned object has changed and a re-render is necessary. In contrastconnectuses shallow comparison. See https://react-redux.js.org/api/hooks#equality-comparisons-and-updates for all details.Therefore to avoid re-renders in the FilterProvider we need to compare the contents of returned array from the user settings selector via
shallowEqualbecause with every call a new array is created and the identity changes.