Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Use correct oldest result date in vulns #3930

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

timopollmeier
Copy link
Member

What

When parsing the result dates for vulnerabilities, the correct field is now used for the oldest result.

Why

When date parsing was added to the Vulnerability model class, the newest date was used accidentally.

References

GEA-414

Checklist

  • Tests

When parsing the result dates for vulnerabilities, the correct field is
now used for the oldest result.

When date parsing was added to the Vulnerability model class, the newest
date was used accidentally.
@timopollmeier timopollmeier requested a review from a team as a code owner December 12, 2023 14:15
Copy link

Conventional Commits Report

Type Number
Bug Fixes 1

🚀 Conventional commits found.

@timopollmeier timopollmeier enabled auto-merge (rebase) December 12, 2023 14:21
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (487b94a) 60.04% compared to head (3c94da6) 60.04%.

Files Patch % Lines
src/gmp/models/vulnerability.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3930   +/-   ##
=======================================
  Coverage   60.04%   60.04%           
=======================================
  Files        1025     1025           
  Lines       25201    25201           
  Branches     7468     7468           
=======================================
  Hits        15133    15133           
  Misses       9124     9124           
  Partials      944      944           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to get a test for that

@timopollmeier timopollmeier merged commit 2d4c73f into main Dec 12, 2023
12 of 13 checks passed
@timopollmeier timopollmeier deleted the fix-vuln-oldest-result-date branch December 12, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants