Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fix jumping behavior when hovering over tabs of open report/alert. #3920

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

a-h-abdelsalam
Copy link
Contributor

@a-h-abdelsalam a-h-abdelsalam commented Nov 24, 2023

What

Prefix pseudo classes with &.

Why

Pseudo selectors no longer work when not prefixed with & in styled-components 6 which causes jumping behavior when hovering over tabs in open reports or alerts. See styled-components/styled-components#4177

References

GEA-382
Closes: #3914

@a-h-abdelsalam a-h-abdelsalam requested a review from a team as a code owner November 24, 2023 11:26
Copy link

Conventional Commits Report

Type Number
Bug Fixes 1

🚀 Conventional commits found.

@cfi-gb
Copy link
Member

cfi-gb commented Nov 24, 2023

You could also add something like e.g. the following to the initial issue description and the issue would be then automatically closed once this PR is merged:

Closes: #3914

Pseudo selectors no longer work when not prefixed with & in
styled-components 6
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9cf69e1) 59.99% compared to head (860f033) 59.99%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3920   +/-   ##
=======================================
  Coverage   59.99%   59.99%           
=======================================
  Files        1023     1023           
  Lines       25177    25177           
  Branches     7473     7473           
=======================================
  Hits        15104    15104           
  Misses       9125     9125           
  Partials      948      948           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timopollmeier timopollmeier added the patch release Create a new patch release label Nov 24, 2023
@timopollmeier timopollmeier merged commit 4335bdf into main Nov 24, 2023
13 checks passed
@timopollmeier timopollmeier deleted the fix-tabs-jumping-behavior-on-hover branch November 24, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch release Create a new patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[22.8.1] - twitching hover experience on scan report navbar
4 participants