Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v16] Bump the electron group with 2 updates #50146

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

ravicious
Copy link
Member

Backport #49610, #50129.

dependabot bot and others added 2 commits December 12, 2024 15:09
* Bump the electron group with 2 updates

Bumps the electron group with 2 updates: [electron](https://github.com/electron/electron) and [electron-builder](https://github.com/electron-userland/electron-builder/tree/HEAD/packages/electron-builder).

Updates `electron` from 33.1.0 to 33.2.1
- [Release notes](https://github.com/electron/electron/releases)
- [Changelog](https://github.com/electron/electron/blob/main/docs/breaking-changes.md)
- [Commits](electron/electron@v33.1.0...v33.2.1)

Updates `electron-builder` from 25.1.7 to 25.1.8
- [Release notes](https://github.com/electron-userland/electron-builder/releases)
- [Changelog](https://github.com/electron-userland/electron-builder/blob/master/packages/electron-builder/CHANGELOG.md)
- [Commits](https://github.com/electron-userland/electron-builder/commits/[email protected]/packages/electron-builder)

---
updated-dependencies:
- dependency-name: electron
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: electron
- dependency-name: electron-builder
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: electron
...

Signed-off-by: dependabot[bot] <[email protected]>

* Turn off electron-builder's notarization

* Add console.log to notarize.js

Otherwise the output during a build would just say this:

> skipped macOS notarization  reason=`notarize` options were set explicitly `false`

which could give the wrong impression that notarization was not done at all.

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Rafał Cieślak <[email protected]>
@ravicious ravicious added the no-changelog Indicates that a PR does not require a changelog entry label Dec 12, 2024
@ravicious ravicious requested review from avatus and gzdunek December 12, 2024 14:11
@ravicious ravicious changed the title [v17] Bump the electron group with 2 updates [v16] Bump the electron group with 2 updates Dec 12, 2024

This comment was marked as off-topic.

@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from gzdunek December 12, 2024 14:20
@ravicious ravicious added this pull request to the merge queue Dec 12, 2024
Merged via the queue into branch/v16 with commit 59b77f9 Dec 12, 2024
42 of 43 checks passed
@ravicious ravicious deleted the r7s/v16/backport-49610-electron-update branch December 12, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport no-changelog Indicates that a PR does not require a changelog entry size/sm ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants