Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle options requests #230

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Handle options requests #230

wants to merge 1 commit into from

Conversation

JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented Dec 23, 2024 •
edited
Loading

Fixes #229
Fixes #184

We weren't handling CORS

@eddeee888
Copy link

Hi @JoviDeCroock ! Thank you for helping move it forward! May I know when we could merge this PR? 🙂

@JoviDeCroock
Copy link
Member Author

@eddeee888 when this gets reviewed

@JoviDeCroock JoviDeCroock mentioned this pull request Dec 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acao acao Awaiting requested review from acao

@yaacovCR yaacovCR Awaiting requested review from yaacovCR

@enisdenjo enisdenjo Awaiting requested review from enisdenjo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CORS error on https://graphql.org/swapi-graphql/ CORS Issue
2 participants
@JoviDeCroock @eddeee888