Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved descend report #1857

Merged
merged 1 commit into from
Jan 19, 2025

Conversation

dave-khuon
Copy link
Contributor

No description provided.

@dave-khuon
Copy link
Contributor Author

Replacing PR #1820. Refactoring get_gender_symbol to utils.py per Nick's suggestion.

@Nick-Hall
Copy link
Member

You probably don't want to instantiate a new Symbols class for each call. Some of our existing code creates a new instance in response to font changes. Does this give us a problem in reports where the system font isn't used and a font can be defined at the paragraph level?

It is also worth noting that the gender field cannot be None, so your function reduces to a single line. Perhaps it is better not to use a function at all. This needs more thought.

@Nick-Hall
Copy link
Member

Actually, we probably don't have a problem with reports. The font issue is related to fallback symbols which are not defined for genders. If a chosen report font doesn't support the gender characters, then there isn't much we can do about it.

Add an option to insert a gender symbol before the person's name.
@Nick-Hall Nick-Hall force-pushed the ImprovedDescendReport branch from 8444e56 to ca6205d Compare January 19, 2025 21:52
@Nick-Hall Nick-Hall merged commit ca6205d into gramps-project:master Jan 19, 2025
2 checks passed
@dave-khuon
Copy link
Contributor Author

Hi Nick,

Since this PR# has been successfully merged, is it ok for me to push similar changes for the other 2 reports (PRs #1819, #1818) that are dependent on the new utils.py to benefit from the same feature benefits? Please let me know.

@Nick-Hall
Copy link
Member

Yes, please go ahead. I'll merge them when you're ready.

@dave-khuon dave-khuon deleted the ImprovedDescendReport branch January 20, 2025 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants