Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: helm - alloy.mounts.extra adds unnecessary newline #2313

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

splichy
Copy link

@splichy splichy commented Dec 23, 2024

PR Description

It's just cosmetics but alloy.mounts.extra is using range for some reason, I have no idea why, but it just adds an unnecessary newline after dash:

# values.yaml
alloy:
    mounts:
      extra:
        - name: tmpalloy
          mountPath: /tmp/alloy
# charts/alloy/templates/controllers/daemonset.yaml
          volumeMounts:
            - name: config
              mountPath: /etc/alloy
            - name: varlog
              mountPath: /var/log
              readOnly: true
            - name: dockercontainers
              mountPath: /var/lib/docker/containers
              readOnly: true
            -
              mountPath: /tmp/alloy
              name: tmpalloy

Change from range to with

          volumeMounts:
            - name: config
              mountPath: /etc/alloy
            - name: varlog
              mountPath: /var/log
              readOnly: true
            - name: dockercontainers
              mountPath: /var/lib/docker/containers
              readOnly: true
            - mountPath: /tmp/alloy
              name: tmpalloy

Which issue(s) this PR fixes

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

@splichy splichy requested a review from a team as a code owner December 23, 2024 19:25
@CLAassistant
Copy link

CLAassistant commented Dec 23, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants