Support for reviewers & assignees

[StefMa]

fixes #215

This time the forgotten reviewers and assignees 🙂

Haven't tested it yet ...

[alextu]

Thanks for your contribution! LGTM, just suggesting a small refactoring and we can merge it once you confirm it works properly (I'll test it too)

[StefMa]

once you confirm it works properly

I can confirm that "it works".

Assignees works perfectly.
See StefMa#6

I “couldn’t test” reviewers. First, I tried to put you as a reviewer, then I got the message from GitHub (via the GitHub API project) that you can only add collaborators as reviewers. Then I set myself as a reviewer, but that didn’t work either. The message was that you can’t set the reviewer to the same person as the author.

Because those errors indicate that there are API calls happening, I would assume that everything works as expected.

However, those errors throw an exception and therefore failed the build. Maybe we want to catch those and report them only via the logger? 🤔 What do you think?

[alextu]

once you confirm it works properly

I can confirm that "it works".

Assignees works perfectly. See StefMa#6

I “couldn’t test” reviewers. First, I tried to put you as a reviewer, then I got the message from GitHub (via the GitHub API project) that you can only add collaborators as reviewers. Then I set myself as a reviewer, but that didn’t work either. The message was that you can’t set the reviewer to the same person as the author.

Because those errors indicate that there are API calls happening, I would assume that everything works as expected.

However, those errors throw an exception and therefore failed the build. Maybe we want to catch those and report them only via the logger? 🤔 What do you think?

I've tested it as well and noticed the same, I'll be able to test it end to end tomorrow. I agree that we should not fail the build since the PR is created, and just output a warning message in that case.

[StefMa]

I changed the code a bit and cleaned it up.
Check it out here: a2a408e

• Add try-catch around addAssignees and requestReviewers and addLabels
• In case of an error, we just log it as warning
• Also I moved the parts after the output of "PR created", because actually this happens afterwards
• I extract methods for each of them

I tested the case of "request review for myself (author)" and the build succeeded, but the error is visible:

I tested to add a label that doesn't exist to check if an error happen.
But actually it just creates that label 🫠
See StefMa#8 🤷
Anyways, according to the method signature it could also throw an IOException.
So better safe than sorry I would say.

[alextu]

Thanks! I've tested it with reviewers as well, looks good, I'll merge the PR soon