Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add onRetry for setting JVM options for fork differently #349

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

U1F984
Copy link

@U1F984 U1F984 commented Nov 8, 2024

Fixes #205, #206, #209, #271.

Going by my last submitted PR I don't expect this one to be accepted either, so I've not bothered to add any tests/docs.

Signed-off-by: Leo Tietz <[email protected]>
@pshevche
Copy link
Member

@U1F984 , thank you for looking into it. I am not convinced that we'll go down this route. It does not cover some of the use cases from #271, like "Print a message on successful retry". Furthermore, we need to think more about the semantics of this callback: should it be invoked once, meaning that the test retry plugin kicked in, or on every retry? I am sorry it takes us so long to get to this topic. We still plan to investigate it, but we'll need to see first how it ranks against other priorities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is there a way to output something when the retry succeeds?
2 participants