Improve compatibility with older GE plugins #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The DV adapter library verifies that an extension instance implements the correct interface names. This commit fixes and issue where this check failed to account for extension objects that were wrapped in nested structures.
New `BuildCacheConfigurationAdapter` provides a transparent adapter for local and remote build cache configuration. The adapter supports the built-in `HttpBuildCache` implementation, as well as GradleEnterprise and Develocity build caches.
Earlier versions of the GE BuildScanExtension did not have `getCapture()`, but instead only had `captureFileFingerprints` to control which build elements were captured. This commit extends the adapter to support these earlier versions.
erichaagdev
approved these changes
Dec 30, 2024
pshevche
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these changes, the
develocity-agent-adapterslibrary will function with a wider range ofcom.gradle.develocity,com.gradle.enterpriseandcom.gradle.build-scanplugin versions.Specific issues that were addressed:
ClassCastExceptionforDevelocityBuildCachewhen instantiatingDevelocityBuildCacheAdapter#94GradleEnterpriseExtensionprior to version 3.11 #95BuildScanExtension.getCapture()which was introduced in plugin version 3.7 #96When combined with bigdaz/common-custom-user-data-gradle-plugin@162c0b4, these improvements will result in a CCUD plugin that is compatible with GradleEnterprise/BuildScan plugins back to versions
1.15and3.0.As a follow up to these changes, we should probably remove the old
BuildCacheAdapterAPI and implementations. These have been replaced byBuildCacheConfigurationAdapter.RemoteBuildCacheAdapter.