Skip to content

Commit

Permalink
Merge pull request #37 from gradle/lptr/support-android-3.2.0-alpha01
Browse files Browse the repository at this point in the history
Support Android 3.2.0-alpha01
  • Loading branch information
lptr authored Feb 5, 2018
2 parents 81c06b9 + 447d8cf commit fe09944
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 10 deletions.
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@

Some Android plugin versions have issues with Gradle's build cache feature. When applied to an Android project this plugin applies workarounds for these issues based on the Android plugin and Gradle versions.

* Supported Gradle versions: 4.1 to 4.4.1, 4.5
* Supported Android versions: 3.0.0, 3.0.1, 3.1.0-beta1
* Supported Gradle versions: all versions between 4.1 and 4.5
* Supported Android versions: 3.0.0, 3.0.1, 3.1.0-beta1, 3.2.0-alpha01

**Note:** With Android 3.1.x the cache-fix plugin is only required if you are using Android's data binding feature.
**Note:** With Android 3.1.x and 3.2.x the cache-fix plugin is only required if you are using Android's data binding feature.

## List of issues

Expand Down
1 change: 1 addition & 0 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ version = ["git", "describe", "--match", "[0-9]*", "--dirty"].execute().text.tri

// Maps supported Android plugin versions to the versions of Gradle that support it
def supportedVersions = [
"3.2.0-alpha01": ["4.5"],
"3.1.0-beta1": ["4.4", "4.4.1", "4.5"],
"3.0.0": ["4.1", "4.2", "4.2.1", "4.3", "4.3.1", "4.4", "4.4.1", "4.5"],
"3.0.1": ["4.1", "4.2", "4.2.1", "4.3", "4.3.1", "4.4", "4.4.1", "4.5"],
Expand Down
14 changes: 7 additions & 7 deletions src/main/groovy/org/gradle/android/AndroidCacheFixPlugin.groovy
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ class AndroidCacheFixPlugin implements Plugin<Project> {
/**
* Fix {@link org.gradle.api.tasks.compile.CompileOptions#getBootClasspath()} introducing relocatability problems for {@link AndroidJavaCompile}.
*/
@AndroidIssue(introducedIn = "3.0.0", fixedIn = "3.1.0-alpha06", link = "https://issuetracker.google.com/issues/68392933")
@AndroidIssue(introducedIn = "3.0.0", fixedIn = ["3.1.0-alpha06", "3.2.0-alpha01"], link = "https://issuetracker.google.com/issues/68392933")
static class AndroidJavaCompile_BootClasspath_Workaround implements Workaround {
@CompileStatic(TypeCheckingMode.SKIP)
@Override
Expand All @@ -123,7 +123,7 @@ class AndroidCacheFixPlugin implements Plugin<Project> {
/**
* Filter the Java annotation processor output folder from compiler arguments to avoid absolute path.
*/
@AndroidIssue(introducedIn = "3.0.0", fixedIn = "3.1.0-alpha06", link = "https://issuetracker.google.com/issues/68391973")
@AndroidIssue(introducedIn = "3.0.0", fixedIn = ["3.1.0-alpha06", "3.2.0-alpha01"], link = "https://issuetracker.google.com/issues/68391973")
static class AndroidJavaCompile_AnnotationProcessorSource_Workaround implements Workaround {
@Override
void apply(WorkaroundContext context) {
Expand All @@ -134,7 +134,7 @@ class AndroidCacheFixPlugin implements Plugin<Project> {
/**
* Override path sensitivity for {@link AndroidJavaCompile#getProcessorListFile()} to {@link PathSensitivity#NONE}.
*/
@AndroidIssue(introducedIn = "3.0.0", fixedIn = "3.1.0-alpha01", link = "https://issuetracker.google.com/issues/68759178")
@AndroidIssue(introducedIn = "3.0.0", fixedIn = ["3.1.0-alpha01", "3.2.0-alpha01"], link = "https://issuetracker.google.com/issues/68759178")
static class AndroidJavaCompile_ProcessorListFile_Workaround implements Workaround {
@CompileStatic(TypeCheckingMode.SKIP)
@Override
Expand Down Expand Up @@ -259,7 +259,7 @@ class AndroidCacheFixPlugin implements Plugin<Project> {
/**
* Override path sensitivity for {@link ExtractAnnotations#getSource()} to {@link PathSensitivity#RELATIVE}.
*/
@AndroidIssue(introducedIn = "3.0.0", fixedIn = "3.1.0-alpha01", link = "https://issuetracker.google.com/issues/68759476")
@AndroidIssue(introducedIn = "3.0.0", fixedIn = ["3.1.0-alpha01", "3.2.0-alpha01"], link = "https://issuetracker.google.com/issues/68759476")
static class ExtractAnnotations_Source_Workaround implements Workaround {
@CompileStatic(TypeCheckingMode.SKIP)
@Override
Expand Down Expand Up @@ -289,7 +289,7 @@ class AndroidCacheFixPlugin implements Plugin<Project> {
/**
* Fix {@link IncrementalTask#getCombinedInput()} and {@link StreamBasedTask#getCombinedInput()} relocatability.
*/
@AndroidIssue(introducedIn = "3.0.0", fixedIn = ["3.0.1", "3.1.0-alpha04"], link = "https://issuetracker.google.com/issues/68771542")
@AndroidIssue(introducedIn = "3.0.0", fixedIn = ["3.0.1", "3.1.0-alpha04", "3.2.0-alpha01"], link = "https://issuetracker.google.com/issues/68771542")
static class CombinedInput_Workaround implements Workaround {
@CompileStatic(TypeCheckingMode.SKIP)
@Override
Expand Down Expand Up @@ -321,7 +321,7 @@ class AndroidCacheFixPlugin implements Plugin<Project> {
/**
* {@link ProcessAndroidResources#getMergeBlameLogFolder()} shouldn't be an {@literal @}{@link org.gradle.api.tasks.Input}.
*/
@AndroidIssue(introducedIn = "3.0.0", fixedIn = ["3.0.1", "3.1.0-alpha02"], link = "https://issuetracker.google.com/issues/68385486")
@AndroidIssue(introducedIn = "3.0.0", fixedIn = ["3.0.1", "3.1.0-alpha02", "3.2.0-alpha01"], link = "https://issuetracker.google.com/issues/68385486")
static class ProcessAndroidResources_MergeBlameLogFolder_Workaround implements Workaround {
@CompileStatic(TypeCheckingMode.SKIP)
@Override
Expand All @@ -336,7 +336,7 @@ class AndroidCacheFixPlugin implements Plugin<Project> {
/**
* {@link com.android.build.gradle.internal.tasks.CheckManifest#getManifest()} should not be an {@literal @}{@link org.gradle.api.tasks.Input}.
*/
@AndroidIssue(introducedIn = "3.0.0", fixedIn = "3.1.0-alpha05", link = "https://issuetracker.google.com/issues/68772035")
@AndroidIssue(introducedIn = "3.0.0", fixedIn = ["3.1.0-alpha05", "3.2.0-alpha01"], link = "https://issuetracker.google.com/issues/68772035")
static class CheckManifest_Manifest_Workaround implements Workaround {
@CompileStatic(TypeCheckingMode.SKIP)
@Override
Expand Down
1 change: 1 addition & 0 deletions src/test/groovy/org/gradle/android/WorkaroundTest.groovy
Original file line number Diff line number Diff line change
Expand Up @@ -24,5 +24,6 @@ class WorkaroundTest extends Specification {
"3.1.0-alpha08" | ["DataBindingDependencyArtifacts"]
"3.1.0-alpha09" | ["DataBindingDependencyArtifacts"]
"3.1.0-beta1" | ["DataBindingDependencyArtifacts"]
"3.2.0-alpha01" | ["DataBindingDependencyArtifacts"]
}
}

0 comments on commit fe09944

Please sign in to comment.