Skip to content

Commit

Permalink
Merge pull request #31 from gradle/lptr/support-gradle-4.5-rc-1
Browse files Browse the repository at this point in the history
Support Gradle 4.5-rc-1
  • Loading branch information
lptr authored Jan 12, 2018
2 parents 30390df + ef4e4f0 commit 8a30709
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 7 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

Some Android plugin versions have issues with Gradle's build cache feature. When applied to an Android project this plugin applies workarounds for these issues based on the Android plugin and Gradle versions.

* Supported Gradle versions: 4.1 to 4.4.1
* Supported Gradle versions: 4.1 to 4.4.1, 4.5-rc-1
* Supported Android versions: 3.0.0, 3.1.0-alpha07

## List of issues
Expand Down
6 changes: 3 additions & 3 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@ version = ["git", "describe", "--match", "[0-9]*", "--dirty"].execute().text.tri

// Maps supported Android plugin versions to the versions of Gradle that support it
def supportedVersions = [
"3.1.0-alpha07": ["4.4", "4.4.1"],
"3.0.0": ["4.1", "4.2", "4.2.1", "4.3", "4.3.1", "4.4", "4.4.1"],
"3.0.1": ["4.1", "4.2", "4.2.1", "4.3", "4.3.1", "4.4", "4.4.1"],
"3.1.0-alpha07": ["4.4", "4.4.1", "4.5-rc-1"],
"3.0.0": ["4.1", "4.2", "4.2.1", "4.3", "4.3.1", "4.4", "4.4.1", "4.5-rc-1"],
"3.0.1": ["4.1", "4.2", "4.2.1", "4.3", "4.3.1", "4.4", "4.4.1", "4.5-rc-1"],
]

repositories {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ class PluginApplicationTest extends AbstractTest {
result.output =~ /Gradle ${quote(gradleVersion)} is not supported by Android cache fix plugin. Supported Gradle versions: .*. Override with -Dorg.gradle.android.cache-fix.ignoreVersionCheck=true./

where:
gradleVersion << ["4.5-20171119235929+0000"]
gradleVersion << ["4.6-20180111235836+0000"]
}

@Unroll
Expand Down
3 changes: 1 addition & 2 deletions src/test/groovy/org/gradle/android/RelocationTest.groovy
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,7 @@ class RelocationTest extends AbstractTest {
relocatedDir.deleteDir()

where:
//[androidVersion, gradleVersion] << Versions.SUPPORTED_VERSIONS_MATRIX.entries().collect { [it.key, it.value] }
[androidVersion, gradleVersion] << [[android("3.1.0-alpha07"), gradle("4.4.1")]]
[androidVersion, gradleVersion] << Versions.SUPPORTED_VERSIONS_MATRIX.entries().collect { [it.key, it.value] }
}

static class ExpectedResults {
Expand Down

0 comments on commit 8a30709

Please sign in to comment.