Minimal changes for Qt6 support #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Untested. Compiles, with a bunch of deprecation warnings. There's likely room for improvement all around.
|
Tested with Qt6 build of Amarok ( https://invent.kde.org/multimedia/amarok/-/merge_requests/132 ). Didn't try logging in, but at least the general functionality accessible without account seems to work, so un-drafting this. |
kdesysadmin
pushed a commit
to KDE/amarok
that referenced
this pull request
Jan 2, 2025
No such release exists yet, but works when libmygpo-qt built with code in gpodder/libmygpo-qt#23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested how much changes are needed on top of the changes in #22 for Qt6 compilation to succeed. Not many it seems (commit bd78964), although I didn't test these in any way yet.