Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added functionality to render tree from html-source instead of url #730

Merged
merged 2 commits into from
Dec 24, 2024
Merged

Added functionality to render tree from html-source instead of url #730

merged 2 commits into from
Dec 24, 2024

Conversation

jaytaph
Copy link
Member

@jaytaph jaytaph commented Dec 24, 2024 •
edited
Loading

The gtk browser alraedy fetches the URL before the drawer. So instead of letting the drawer fetching the url, we provide the html source

@jaytaph jaytaph requested a review from Sharktheone December 24, 2024 11:39
Sharktheone
Sharktheone requested changes Dec 24, 2024
View reviewed changes
crates/gosub_interface/src/draw.rs Outdated Show resolved Hide resolved
crates/gosub_renderer/src/render_tree.rs Outdated Show resolved Hide resolved
@jaytaph jaytaph mentioned this pull request Dec 24, 2024
Open
@jaytaph jaytaph requested a review from Sharktheone December 24, 2024 14:12
@jaytaph jaytaph merged commit 32c75c9 into gosub-io:main Dec 24, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sharktheone Sharktheone Sharktheone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaytaph @Sharktheone