make clippy more strict #467
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sharktheone
force-pushed
the
clippy/make-it-stricter
branch
from
429b5a7 to
8f147b0
Compare
|
Lets close this one for now. I think we cannot reasonably salvage this |
|
Yes, and it has so many conflicts. But maybe we should keep it as an reminder. The main problem is that Clippy can't auto fix lints if there are more than 10 or so. I think we should open an issue on the Clippy side. And I mean we probably have a couple thousand with this project. |
|
Setting up a new issue #752 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes clippy lints more strict, I didn't (yet) fix all errors that were created by changing the configuration.