Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Ensure MultipartForm is properly restored to the original request #777

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions mux.go
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,14 @@ func (r *Router) ServeHTTP(w http.ResponseWriter, req *http.Request) {
if r.Match(req, &match) {
handler = match.Handler
if handler != nil {
// Note: The defer statement is used to assign the value of req.MultipartForm back to the original request's MultipartForm (originReq) when the function returns.
// This is necessary because the 'req' variable may be modified later in the code, and there is a risk that MultipartForm may not be properly assigned to the original request (originReq).
// Since the 'req' is a shallow copy of the original request, any changes to req.MultipartForm during the request handling might not reflect back to the original request.
// By using 'defer', we ensure that the MultipartForm is correctly restored to the original request when the function exits.
defer func(originReq *http.Request) {
originReq.MultipartForm = req.MultipartForm
}(req)

// Populate context for custom handlers
if r.omitRouteFromContext {
// Only populate the match vars (if any) into the context.
Expand Down
Loading