Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for MethodNotAllowed error #774

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Tests for MethodNotAllowed error #774

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0ff8ce
test: added more test for MethodNotAllowed
rodionovv Nov 4, 2024
f0fb0e8
refactor: changed req method for test TestMethodNotAllowed_diffMethod…
rodionovv Nov 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
172 changes: 171 additions & 1 deletion mux_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2853,7 +2853,177 @@ func Test_copyRouteConf(t *testing.T) {
}
}

func TestMethodNotAllowed(t *testing.T) {
func TestMethodNotAllowed_diffMethods_bothHandleFuncs(t *testing.T) {
handler := func(w http.ResponseWriter, r *http.Request) { w.WriteHeader(http.StatusOK) }
router := NewRouter()

router.HandleFunc("/thing", handler).Methods(http.MethodPost)
router.HandleFunc("/something", handler).Methods(http.MethodGet)

w := NewRecorder()
req := newRequest(http.MethodGet, "/thing")

router.ServeHTTP(w, req)

if w.Code != http.StatusMethodNotAllowed {
t.Fatalf("Expected status code 405 (got %d)", w.Code)
}
}

func TestMethodNotAllowed_diffMethods_handleFuncMethods(t *testing.T) {
handler := func(w http.ResponseWriter, r *http.Request) { w.WriteHeader(http.StatusOK) }
router := NewRouter()

router.HandleFunc("/thing", handler).Methods(http.MethodPost)
router.Methods(http.MethodGet).Path("/something").Handler(http.HandlerFunc(handler))

w := NewRecorder()
req := newRequest(http.MethodGet, "/thing")

router.ServeHTTP(w, req)

if w.Code != http.StatusMethodNotAllowed {
t.Fatalf("Expected status code 405 (got %d)", w.Code)
}
}

func TestMethodNotAllowed_diffMethods_handleFuncPath(t *testing.T) {
handler := func(w http.ResponseWriter, r *http.Request) { w.WriteHeader(http.StatusOK) }
router := NewRouter()

router.HandleFunc("/thing", handler).Methods(http.MethodPost)
router.Path("/something").Methods(http.MethodGet).Handler(http.HandlerFunc(handler))

w := NewRecorder()
req := newRequest(http.MethodGet, "/thing")

router.ServeHTTP(w, req)

if w.Code != http.StatusMethodNotAllowed {
t.Fatalf("Expected status code 405 (got %d)", w.Code)
}
}

func TestMethodNotAllowed_diffMethods_methodsHandleFunc(t *testing.T) {
handler := func(w http.ResponseWriter, r *http.Request) { w.WriteHeader(http.StatusOK) }
router := NewRouter()

router.Methods(http.MethodPost).Path("/thing").Handler(http.HandlerFunc(handler))
router.HandleFunc("/something", handler).Methods(http.MethodGet)

w := NewRecorder()
req := newRequest(http.MethodGet, "/thing")

router.ServeHTTP(w, req)

if w.Code != http.StatusMethodNotAllowed {
t.Fatalf("Expected status code 405 (got %d)", w.Code)
}
}

func TestMethodNotAllowed_diffMethods_bothMethods(t *testing.T) {
handler := func(w http.ResponseWriter, r *http.Request) { w.WriteHeader(http.StatusOK) }
router := NewRouter()

router.Methods(http.MethodPost).Path("/thing").Handler(http.HandlerFunc(handler))
router.Methods(http.MethodGet).Path("/something").Handler(http.HandlerFunc(handler))

w := NewRecorder()
req := newRequest(http.MethodGet, "/thing")

router.ServeHTTP(w, req)

if w.Code != http.StatusMethodNotAllowed {
t.Fatalf("Expected status code 405 (got %d)", w.Code)
}
}

func TestMethodNotAllowed_diffMethods_methodsPath(t *testing.T) {
handler := func(w http.ResponseWriter, r *http.Request) { w.WriteHeader(http.StatusOK) }
router := NewRouter()

router.Methods(http.MethodPost).Path("/thing").Handler(http.HandlerFunc(handler))
router.Path("/something").Methods(http.MethodGet).Handler(http.HandlerFunc(handler))

w := NewRecorder()
req := newRequest(http.MethodGet, "/thing")

router.ServeHTTP(w, req)

if w.Code != http.StatusMethodNotAllowed {
t.Fatalf("Expected status code 405 (got %d)", w.Code)
}
}

func TestMethodNotAllowed_diffMethods_pathHandleFunc(t *testing.T) {
handler := func(w http.ResponseWriter, r *http.Request) { w.WriteHeader(http.StatusOK) }
router := NewRouter()

router.Path("/thing").Methods(http.MethodPost).Handler(http.HandlerFunc(handler))
router.HandleFunc("/something", handler).Methods(http.MethodGet).Handler(http.HandlerFunc(handler))

w := NewRecorder()
req := newRequest(http.MethodGet, "/thing")

router.ServeHTTP(w, req)

if w.Code != http.StatusMethodNotAllowed {
t.Fatalf("Expected status code 405 (got %d)", w.Code)
}
}

func TestMethodNotAllowed_diffMethods_pathMethods(t *testing.T) {
handler := func(w http.ResponseWriter, r *http.Request) { w.WriteHeader(http.StatusOK) }
router := NewRouter()

router.Path("/thing").Methods(http.MethodPost).Handler(http.HandlerFunc(handler))
router.Methods(http.MethodGet).Path("/something").Handler(http.HandlerFunc(handler))

w := NewRecorder()
req := newRequest(http.MethodGet, "/thing")

router.ServeHTTP(w, req)

if w.Code != http.StatusMethodNotAllowed {
t.Fatalf("Expected status code 405 (got %d)", w.Code)
}
}

func TestMethodNotAllowed_diffMethods_bothPath(t *testing.T) {
handler := func(w http.ResponseWriter, r *http.Request) { w.WriteHeader(http.StatusOK) }
router := NewRouter()

router.Path("/thing").Methods(http.MethodPost).Handler(http.HandlerFunc(handler))
router.Path("/something").Methods(http.MethodGet).Handler(http.HandlerFunc(handler))

w := NewRecorder()
req := newRequest(http.MethodGet, "/thing")

router.ServeHTTP(w, req)

if w.Code != http.StatusMethodNotAllowed {
t.Fatalf("Expected status code 405 (got %d)", w.Code)
}
}

func TestMethodNotAllowed_diffMethods_diffReqMethod(t *testing.T) {
handler := func(w http.ResponseWriter, r *http.Request) { w.WriteHeader(http.StatusOK) }
router := NewRouter()

router.Path("/thing").Methods(http.MethodPost).Handler(http.HandlerFunc(handler))
router.Path("/something").Methods(http.MethodGet).Handler(http.HandlerFunc(handler))

w := NewRecorder()
req := newRequest(http.MethodDelete, "/thing")

router.ServeHTTP(w, req)

if w.Code != http.StatusMethodNotAllowed {
t.Fatalf("Expected status code 405 (got %d)", w.Code)
}
}

func TestMethodNotAllowed_sameMethods(t *testing.T) {
handler := func(w http.ResponseWriter, r *http.Request) { w.WriteHeader(http.StatusOK) }
router := NewRouter()
router.HandleFunc("/thing", handler).Methods(http.MethodGet)
Expand Down
Loading