[WIP] #132 Fallback to selecting hidden password field #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e.g. as used on Google multi-step login page Signed-off-by: Patrick Harböck <[email protected]>
|
Another currently not working login page to investigate could be bitbucket.org |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@martinhoefling can you give me some thoughts on the
isVisiblelogic?I'm not 100% sure why we have that.
With these changes, the Google login page works, I just need to hit "Enter" or click the "Next" button two times.
At least the page remembers the password when it is being filled in on the "email/username" input page. But I am not sure if other websites also use a similar pattern.