Bug Report: code check call.Err !=nil but return a nil value error err

[alingse]

Summary

do you mean return call.Err or just return nil to ignore the call.Err ?

Steps To Reproduce

Expected behavior

Environment

• OS: [e.g. Mac OS X High Sierra, Ubuntu 18.04, Windows 10, ...]
• OS version: [uname -a]
• gopass Version: [gopass version]
• Installation method: [e.g. from source, brew, gopass repo]

Additional context

I create a linter to detect code that returns a non-relevant nilness error bug. I checked the top 1000 GitHub Go repositories and found this, all result listed in alingse/sundrylint#4

[dominikschulz]

Please provide more details.

[alingse]

@dominikschulz

gopass/internal/notify/notify_dbus.go

Lines 23 to 34 in bd408d6

	if err != nil {
	debug.Log("DBus failure: %s", err)
	return err
	}
	obj := conn.Object("org.freedesktop.Notifications", "/org/freedesktop/Notifications")
	call := obj.Call("org.freedesktop.Notifications.Notify", 0, "gopass", uint32(0), iconURI(ctx), subj, msg, []string{}, map[string]dbus.Variant{"transient": dbus.MakeVariant(true)}, int32(3000))
	if call.Err != nil {
	debug.Log("DBus notification failure: %s", call.Err)
	return err

check if call.Err != nil but just return a already nil value err

[dominikschulz]

Ha, looks legit, indeed. Thanks.

[Denis-Kuso]

I’d like to work on fixing this. Seems like just a small correction in the variable return. Will submit a PR soon.